From a013bced012b2c0c20b3a3d386f3038d8ee38c33 Mon Sep 17 00:00:00 2001 From: TrellixVulnTeam Date: Tue, 15 Nov 2022 01:38:20 +0000 Subject: [PATCH] Adding tarfile member sanitization to extractall() --- scripts/download-blender.py | 21 ++++++++++++++++++++- 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/scripts/download-blender.py b/scripts/download-blender.py index 3da842b..3685a2a 100644 --- a/scripts/download-blender.py +++ b/scripts/download-blender.py @@ -34,7 +34,26 @@ if(platform.system() == 'Linux'): urllib.request.urlretrieve(linuxURL, './dependencies/linux/blender.tar.xz') print("Extracting linux version") with tarfile.open('./dependencies/linux/blender.tar.xz') as tfile: - tfile.extractall('./dependencies/linux') + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(tfile, "./dependencies/linux") print("Adjust linux version") oldLinuxName = linuxURL.split('/')[-1].replace('.tar.xz', '')